Open
Conversation
Firestar99
force-pushed
the
naga-wgsl-v2
branch
from
5fcf85a to
846794b
Compare
nazar-pc
reviewed
Dec 18, 2025
Comment on lines
+23
to
+26
| use-installed-tools = ["spirv-tools/use-installed-tools", "naga"] | ||
| # If enabled will compile and link the C++ code for the spirv tools, the compiled | ||
| # version is preferred if both this and `use-installed-tools` are enabled | ||
| use-compiled-tools = ["spirv-tools/use-compiled-tools"] | ||
| use-compiled-tools = ["spirv-tools/use-compiled-tools", "naga"] |
Contributor
There was a problem hiding this comment.
Hm, this effectively makes naga non-optional if I'm reading it correctly. Is it intentional?
Member
Author
There was a problem hiding this comment.
That's from the old PR, added with comment
wgsl: enable naga feature by default, cargo-gpu can't handle it
So this was more a hack than anything else. I'll have a look what the compile time impact is, and if it's actually significant (which next to spirv-tools-sys may not be), look into making it optional and supported by cargo-gpu.
Contributor
There was a problem hiding this comment.
I'm wondering if naga should really be a dependency of either of those two features. Why not let user specify it explicitly instead?
Member
Author
There was a problem hiding this comment.
cargo-gpu can't handle it
we'd need to build the infra in cargo-gpu first
Merged
Firestar99
force-pushed
the
naga-wgsl-v2
branch
2 times, most recently
from
32d2899 to
6e2f673
Compare
Firestar99
force-pushed
the
target-decl
branch
from
d637f7c to
65e4222
Compare
Firestar99
force-pushed
the
naga-wgsl-v2
branch
from
6e2f673 to
231bcb7
Compare
Firestar99
force-pushed
the
target-decl
branch
from
65e4222 to
5b9ad34
Compare
Firestar99
force-pushed
the
naga-wgsl-v2
branch
from
231bcb7 to
0209a20
Compare
Firestar99
force-pushed
the
target-decl
branch
from
5b9ad34 to
6ffd84d
Compare
Firestar99
force-pushed
the
naga-wgsl-v2
branch
from
0209a20 to
ccaa0d6
Compare
Firestar99
force-pushed
the
naga-wgsl-v2
branch
from
ccaa0d6 to
2ace4a2
Compare
Firestar99
force-pushed
the
naga-wgsl-v2
branch
from
2ace4a2 to
3f4b2fa
Compare
Firestar99
force-pushed
the
naga-wgsl-v2
branch
from
3f4b2fa to
1616f56
Compare
Firestar99
force-pushed
the
naga-wgsl-v2
branch
from
1616f56 to
d2f898e
Compare
Firestar99
force-pushed
the
target-decl
branch
2 times, most recently
from
b933e50 to
4b595cd
Compare
Firestar99
force-pushed
the
naga-wgsl-v2
branch
from
842df37 to
7052f39
Compare
Firestar99
force-pushed
the
naga-wgsl-v2
branch
from
7052f39 to
24dd3ae
Compare
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires #491
Supersedes #280
Adds
spirv-unknown-naga-wgsltarget for built-in naga transpilation to wgsl. Further naga targets could be added easily.Quite a lot compiletest fail with naga, common reasons include:
u8&i8For now, I'd just accept that any naga targets won't pass our compiletest suite and not add a CI step for that.